-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix(containerregistry): added preview version decorator to properties incorrectly flagged as stable #39455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(containerregistry): added preview version decorator to properties incorrectly flagged as stable #39455
Conversation
… incorrectly flagged as stable
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
northtyphoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@CodeJourneys could you wait for us to further confirm if there's any more additional preview features being added into the stable version? @kazrael2119 could provide further investigation result. |
|
Sorry for my mistake of introducing breaking changes when doing typespec conversion. |
|
@CodeJourneys Operation In your old swagger, you added this example under |
Thanks for the review @kazrael2119 and no worries about the miss. It's a good learning for all of us. I'm not sure I understand your question about the example file As far as I understand, in the PR to release 2025-11-01 stable, there was an orphaned examples file RegistryCreateAbac.json, which was present, but not referenced in the API swagger json, as shown here. However, in the latest version of the 2025-11-01 swagger, it is referenced as an example for Registries_Create (put). This reference was added in one of the Typespec conversion PRs, as shown here. Are you asking whether adding the reference as an example is okay, rather than intentionally leaving it orphaned? I'm not aware of any reason we would ever want an orphaned example, but perhaps I'm missing something. cc: @lizMSFT in case I may be missing context on the RegistryCreateAbac example specifically |
|
@kazrael2119 Thanks for catching this! We do need this example for Registries_Create: I missed including this example in the Swagger file previously |
|
@mcgallan told me that we have some description diff in 2025-06-01-preview during typespec conversion: 2: description in Do you have any concerns about these description diff? |
This PR corrects several properties in the ContainerRegistry control plane API specification that were missing the versioning decorator, incorrectly causing these preview properties to show as stable. These are corrected in this PR.