Skip to content

Conversation

@CodeJourneys
Copy link
Contributor

This PR corrects several properties in the ContainerRegistry control plane API specification that were missing the versioning decorator, incorrectly causing these preview properties to show as stable. These are corrected in this PR.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview resource-manager TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.ContainerRegistry
Go sdk/resourcemanager/containerregistry/armcontainerregistry
JavaScript @azure/arm-containerregistry
Java com.azure.resourcemanager:azure-resourcemanager-containerregistry-generated
Python azure-mgmt-containerregistry
Swagger Microsoft.ContainerRegistry-Registry

@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review NotReadyForARMReview and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2026
Copy link
Member

@northtyphoon northtyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikekistler mikekistler added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Jan 12, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview ARMAutoSignedOff labels Jan 12, 2026
@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 12, 2026
@CodeJourneys CodeJourneys added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 12, 2026
@qiaozha
Copy link
Member

qiaozha commented Jan 15, 2026

@CodeJourneys could you wait for us to further confirm if there's any more additional preview features being added into the stable version? @kazrael2119 could provide further investigation result.

@kazrael2119
Copy link
Member

Sorry for my mistake of introducing breaking changes when doing typespec conversion.
@mcgallan and I have double confirmed the differences between origin swagger and the generated swagger.
There's no additional properties being added into the stable version.

@kazrael2119
Copy link
Member

@CodeJourneys Operation Registries_Create added a new example reference with RegistryCreateAbac when doing typespec conversion,

In your old swagger, you added this example under examples in https://github.com/Azure/azure-rest-api-specs/pull/37748/files#diff-1c5bbd1e385981c6e7dca82ccac27d4b7e9c82b870021f822693adebe0b11567 but didn't add this reference in the swagger file. Do you have any concerns about this?

@CodeJourneys
Copy link
Contributor Author

@CodeJourneys Operation Registries_Create added a new example reference with RegistryCreateAbac when doing typespec conversion,

In your old swagger, you added this example under examples in https://github.com/Azure/azure-rest-api-specs/pull/37748/files#diff-1c5bbd1e385981c6e7dca82ccac27d4b7e9c82b870021f822693adebe0b11567 but didn't add this reference in the swagger file. Do you have any concerns about this?

Thanks for the review @kazrael2119 and no worries about the miss. It's a good learning for all of us. I'm not sure I understand your question about the example file RegistryCreateAbac.json. Could you clarify a bit?

As far as I understand, in the PR to release 2025-11-01 stable, there was an orphaned examples file RegistryCreateAbac.json, which was present, but ⁠not referenced in the API swagger json, as shown here. However, in the latest version of the 2025-11-01 swagger, it is ⁠referenced as an example for Registries_Create (put). This reference was added in one of the Typespec conversion PRs, as shown here.

Are you asking whether adding the reference as an example is okay, rather than intentionally leaving it orphaned? I'm not aware of any reason we would ever want an orphaned example, but perhaps I'm missing something. cc: @lizMSFT in case I may be missing context on the RegistryCreateAbac example specifically

@lizMSFT
Copy link
Member

lizMSFT commented Jan 15, 2026

@kazrael2119 Thanks for catching this! We do need this example for Registries_Create:

          "RegistryCreateAbac": {
            "$ref": "./examples/RegistryCreateAbac.json"
          }

I missed including this example in the Swagger file previously

@kazrael2119
Copy link
Member

kazrael2119 commented Jan 16, 2026

@mcgallan told me that we have some description diff in 2025-06-01-preview during typespec conversion:
1: description inArchiveVersions_Creat
old: Creates a archive for a container registry with the specified parameters.
new: Creates a archive version for a container registry with the specified parameters.

2: description in ArchiveVersionProperties:
old: The properties of an export pipeline.
new: The properties of an archive version.

Do you have any concerns about these description diff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Container Registry PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants